Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix resize #25

Merged
merged 7 commits into from
Oct 15, 2021
Merged

fix resize #25

merged 7 commits into from
Oct 15, 2021

Conversation

lcdsmao
Copy link
Collaborator

@lcdsmao lcdsmao commented Oct 14, 2021 •
edited
Loading

related #22

  • Throw an error if hit max try count / max large size
  • Only resize the axis that is needed resize
  • Find Srollable instead of ScrollView
    • This lets us no need to set ScrollController manually

@lcdsmao lcdsmao requested a review from KyoheiG3 October 14, 2021 10:09
@lcdsmao lcdsmao merged commit a99060d into main Oct 15, 2021
@lcdsmao lcdsmao deleted the fix-resize branch October 15, 2021 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyoheiG3 KyoheiG3 Awaiting requested review from KyoheiG3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lcdsmao