Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure: fix subnet reserved ranges #64

Open
wants to merge 2 commits into
base: release
Choose a base branch
from

Conversation

zmb3
Copy link

@zmb3 zmb3 commented Oct 5, 2020

The reserved range is a range of IP addresses, so the output should reserve the first 10 IPs in each subnet, not only the 10th IP.
(This is already the case for the AWS and GCP templates in this repo.)

With this change, the output shows:

➜ terraform output stable_config_pas | jq .pas_subnet_range
"10.0.0.1-10.0.0.10"

The reserved range is a range of IP addresses,
so the output should reserve the first 10 IPs
in each subnet, not only the 10th IP.
@zmb3
Copy link
Author

zmb3 commented Oct 5, 2020

Note: my editor automatically formatted the changed files to match HCL convention of lining up the =. Let me know if you'd rather I back out the formatting changes for a cleaner diff, or keep the formatting changes here so the formatting is consistent.

@jaristiz
Copy link
Contributor

Looks good to me, will schedule to merge it.

@sneal
Copy link
Contributor

sneal commented May 24, 2022

Thanks @zmb3 you're the best!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants