-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide during empty days? #3
Comments
Thanks for the nice feedback. Much appreciated! If there is no lesson for a particular day then the module shows "No lessons today". The text appears when there is no weekday entry in the lessons array. For instance, the first example in the README.md file has no "sat" (Saturday) item defined. Does this solve your problem or do you want to hide the module completely? In this case I could extend it with a config "hideOnNoLessonsDays" or similar. I'm opening a separate issue for the wrong behavior of "showWeekdayinHeader". |
Thanks for getting back. I think if there was a “hideOnNoLessonDays” (false/true) in the configuration for the entire module to be hidden, that would be a worthwhile addition. If you have the time and feel inclined to do that. |
+1 for this one. To clarify my problem, it is that the header is always shown even when there is no schedule for that day. If the whole module can't be hidden, I guess it would be ok to just hide the header (not sure of how the MM API looks). Great module btw! |
Great module you've made here; there is a lot of use for it. But I was wondering if there is any native, or recommended, way for hiding the module during days that don't have any "lessons"?
The schedule modular that also seems popular only specifies time of day. But I'd like to have your module hidden three days a week, and displayed four days a week (the days that have something included).
Any advice is appreciated. Great work!
The text was updated successfully, but these errors were encountered: