Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: Add left side operator info for hash join execution summary | tidb-test=pr/2436 #57814

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

planner: Add left side operator info for hash join execution summary | tidb-test=pr/2436 #57814

wants to merge 26 commits into from
+621 −604

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Nov 29, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: close #57819 ref #56233

Problem Summary:

What changed and how does it work?

  1. Add join operator's left side info for non-inner join
  2. In distsql,util: Add executor open close time into its total consume time #56236, open/close time below 1ms are not displayed to make execution summary shorter. After discussion with project manager, we believe showing them in all situations will be more reasonable, because we can solve readability issue by other mechanisms.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 29, 2024
@tiprow tiprow
Copy link

tiprow bot commented Nov 29, 2024

Hi @yibin87. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Little refact
c71ea8d 
Signed-off-by: yibin <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Nov 29, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 29, 2024

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 29, 2024
@yibin87 yibin87 changed the title planner: Add left sie operator info for hash join execution summary planner: Add left sie operator info for hash join execution summary | tidb-test=pr/2436 Nov 29, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 29, 2024

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 29, 2024

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 29, 2024
@yibin87
update ut reference
b64b8a7 
Signed-off-by: yibin <[email protected]>
@yibin87
Copy link
Contributor Author

yibin87 commented Nov 29, 2024

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Nov 29, 2024

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Copy link
Contributor Author

yibin87 commented Nov 29, 2024

/test check-dev

@yibin87
Copy link
Contributor Author

yibin87 commented Nov 29, 2024

/test check-dev_2

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 29, 2024

@yibin87: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test build

/test check-dev

/test check-dev2

/test mysql-test

/test pull-br-integration-test

/test pull-integration-ddl-test

/test pull-integration-e2e-test

/test pull-lightning-integration-test

/test pull-mysql-client-test

/test pull-unit-test-ddlv1

/test unit-test

The following commands are available to trigger optional jobs:

/test pingcap/tidb/canary_ghpr_unit_test

/test pull-common-test

/test pull-e2e-test

/test pull-integration-common-test

/test pull-integration-copr-test

/test pull-integration-jdbc-test

/test pull-integration-mysql-test

/test pull-integration-nodejs-test

/test pull-integration-python-orm-test

/test pull-sqllogic-test

/test pull-tiflash-test

Use /test all to run the following jobs that were automatically triggered:

pingcap/tidb/ghpr_build

pingcap/tidb/ghpr_check

pingcap/tidb/ghpr_check2

pingcap/tidb/ghpr_mysql_test

pingcap/tidb/ghpr_unit_test

pingcap/tidb/pull_integration_ddl_test

pingcap/tidb/pull_integration_e2e_test

pingcap/tidb/pull_mysql_client_test

In response to this:

/test check-dev_2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
Update ref
f3c9b11 
Signed-off-by: yibin <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Dec 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.4766%. Comparing base (b2f29ee) to head (e01baef).
Report is 16 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #57814        +/-   ##
================================================
+ Coverage   72.8801%   73.4766%   +0.5964%     
================================================
  Files          1677       1677                
  Lines        464450     466985      +2535     
================================================
+ Hits         338492     343125      +4633     
+ Misses       105062     103019      -2043     
+ Partials      20896      20841        -55
Flag Coverage Δ
integration 43.3793% <100.0000%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.7673% <ø> (ø)
parser ∅ <ø> (∅)
br 45.7227% <ø> (+0.0090%) ⬆️

@yibin87
update ref
9ff38ad 
Signed-off-by: yibin <[email protected]>
@yibin87
Update ut ref
c0ee772 
Signed-off-by: yibin <[email protected]>
@yibin87
Update ref
5367fe3 
Signed-off-by: yibin <[email protected]>
@yibin87
update ref
04c7de6 
Signed-off-by: yibin <[email protected]>
@yibin87
Update ref
6874d71 
Signed-off-by: yibin <[email protected]>
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 2, 2024

/cc @windtalker @winoros

@yibin87
Copy link
Contributor Author

yibin87 commented Dec 2, 2024

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 2, 2024

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yibin87
update ref
afd1252 
Signed-off-by: yibin <[email protected]>
@yibin87
Remove useless file
e92b967 
Signed-off-by: yibin <[email protected]>
@yibin87
update ref
513609b 
Signed-off-by: yibin <[email protected]>
windtalker
windtalker approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 2, 2024
@windtalker windtalker changed the title planner: Add left sie operator info for hash join execution summary | tidb-test=pr/2436 planner: Add left side operator info for hash join execution summary | tidb-test=pr/2436 Dec 2, 2024
@yibin87
Copy link
Contributor Author

yibin87 commented Dec 2, 2024

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Dec 2, 2024

@yibin87: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024 •
edited
Loading

@yibin87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test e01baef link true /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 2, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 2, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-02 08:00:17.203785854 +0000 UTC m=+1055404.823440372: ☑️ agreed by windtalker.
  • 2024-12-02 12:07:24.644091896 +0000 UTC m=+1070232.263746412: ☑️ agreed by winoros.

@tiprow tiprow
Copy link

tiprow bot commented Dec 2, 2024

@yibin87: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow e01baef link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@windtalker windtalker windtalker approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Join's left side info in execution summary
3 participants
@yibin87 @windtalker @winoros