PDF now can include images #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note, I chose image width based on the decreased margins in my other PR |
pin3da
reviewed
Sep 22, 2024
| @@ -30,7 +31,9 @@ function walk (_path, depth) { | |||
| ans += '\n' + section[depth] + file + '}\n' + walk(f, depth + 1) | |||
| } else if (path.extname(f) in extensions) { | |||
| ans += '\n' + section[depth] + file.split('.')[0] + '}\n' | |||
| if (path.extname(f) !== '.tex') { | |||
| if (path.extname(f) === '.png') { | |||
There was a problem hiding this comment.
It might be interesting to support other file formats too.
We might have a set of "image file extensions" and then check if the current one is in the set.
WDYT?
|
Thanks for the contributions! Happy to merge as-is, or with the suggested changes. I'll wait for your reply first. (same in the other PR). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.