Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added open context menu item #791

Merged
merged 7 commits into from
Dec 3, 2024

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented Dec 3, 2024

Changes in this pull request

Resolves #753

Additional info

This pull request introduces a new feature to the asset editor by adding an "Open" context menu item for assets. The changes involve importing and using the useOpen hook, creating the useOpen hook, and updating the translations file.

New Feature: Open Context Menu Item

@Corepex Corepex requested a review from markus-moser December 3, 2024 08:06
@Corepex Corepex self-assigned this Dec 3, 2024
Copy link
Contributor

@markus-moser markus-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comment, other then that it LGTM and it worked as it should.

assets/js/src/core/modules/element/actions/open/open.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 3, 2024

@Corepex Corepex requested a review from markus-moser December 3, 2024 14:00
Copy link
Contributor

@markus-moser markus-moser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM now

@Corepex Corepex merged commit 02d1ed6 into 1.x Dec 3, 2024
1 check passed
@Corepex Corepex deleted the 753-missing-asset-context-menu-actions-open branch December 3, 2024 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing asset context menu actions
2 participants