-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added open
context menu item
#791
Conversation
…ctions-open' into 753-missing-asset-context-menu-actions-open
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comment, other then that it LGTM and it worked as it should.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, LGTM now
Changes in this pull request
Resolves #753
Additional info
This pull request introduces a new feature to the asset editor by adding an "Open" context menu item for assets. The changes involve importing and using the
useOpen
hook, creating theuseOpen
hook, and updating the translations file.New Feature: Open Context Menu Item
assets/js/src/core/modules/asset/editor/types/folder/tab-manager/tabs/preview/flex-container.tsx
: Added import foruseOpen
, and includedopenContextMenuItem
in theFlexContainer
component's dropdown items. [1] [2] [3]assets/js/src/core/modules/element/actions/open/open.tsx
: Created theuseOpen
hook which provides theopenContextMenuItem
function to generate a context menu item for opening assets.translations/studio.en.yaml
: Added a new translation keyelement.open
for the "Open" context menu item.