Error Handling #752
Merged
Error Handling #752
+2,404
−4,423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
eb79427 to
b18249c
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
344c2f8 to
3a68a20
Compare
vin0401
requested changes
Nov 29, 2024
There was a problem hiding this comment.
@markus-moser @ValeriaMaltseva
What do you think about my comments?
I still would love to see a bit different approach here.
Just let me know, when I'm on a completely wrong track. xD
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
7593ec4 to
be47a2d
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
b2c6bad to
1401e67
Compare
…instead of throwing the error
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
b34bd60 to
d183157
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
7ff7390 to
876ca99
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
ecbb5a2 to
8fa7d5e
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
be975cf to
82eb638
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
b94db4b to
7e6b13a
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
422fc47 to
cbb764c
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
e05b611 to
a30df1b
Compare
vin0401
reviewed
Dec 3, 2024
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
347ca59 to
0c1734b
Compare
ValeriaMaltseva
force-pushed
the
639-error-handling
branch
from
36e4a1c to
84b1acf
Compare
|
vin0401
approved these changes
Dec 11, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: #639