Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginx.md #926

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update nginx.md #926

wants to merge 4 commits into from

Conversation

williamtrelawny
Copy link
Contributor

@williamtrelawny williamtrelawny commented Sep 4, 2023 •
edited
Loading

  • Updated referenced PHP version (7.3 -> 8.2) to match current Debian version (12).
  • Also added clarity to PHP installation instructions to help the user find the right packages (version numbers are in package names so it makes it confusing).

Thank you for your contribution to the Pi-hole Community!

Please read the comments below to help us consider your Pull Request.

We are all volunteers and completing the process outlined will help us review your commits quicker.

Please make sure you

  1. Base your code and PRs against the repositories developmental branch.
  2. Sign Off all commits as we enforce the DCO for all contributions
  3. Sign all your commits as they must have verified signatures
  4. File a pull request for any change that requires changes to our documentation at our documentation repo

What does this PR aim to accomplish?:

How does this PR accomplish the above?:

Link documentation PRs if any are needed to support this PR:

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
  • I have read the above and my PR is ready for review. Check this box to confirm

@williamtrelawny
Update nginx.md
ecc8289 
- Updated referenced PHP version (7.3 -> 8.2) to match current Debian version (12).
- Also added clarity to PHP installation instructions to help the user find the right packages (version numbers are in package names so it makes it confusing).

Signed-off-by: William Trelawny <[email protected]>
@netlify
Copy link

netlify bot commented Sep 4, 2023 •
edited
Loading

✅ Deploy Preview for pihole-docs ready!

Name Link
🔨 Latest commit 34bd7f3
🔍 Latest deploy log https://app.netlify.com/sites/pihole-docs/deploys/64f649ce6629ea0008d44608
😎 Deploy Preview https://deploy-preview-926--pihole-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@williamtrelawny
Update nginx.md
6bf2dc4 
changed spacing per code review failure

Signed-off-by: William Trelawny <[email protected]>
@williamtrelawny
Update nginx.md
252e479 
- Remove PHP versioning from install instructions because it was actually unnecessary.
- Added version info to systemd service commands as well as instructions on how to find user's version installed
- Change refs to SysVInit to systemd syntax

Signed-off-by: William Trelawny <[email protected]>
@williamtrelawny
Update nginx.md
34bd7f3 
Fixed ordered list numbering

Signed-off-by: William Trelawny <[email protected]>
@clayoster clayoster mentioned this pull request Nov 19, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@williamtrelawny