Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-and-publish.yml #1664

Closed
wants to merge 1 commit into from
Closed

Conversation

jommeke22f
Copy link

@jommeke22f jommeke22f commented Nov 28, 2024

{Please select 'base: dev' as target branch above! (you can delete this line)}

Description

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@yubiuser
Copy link
Member

Why do you think this change is necessary?

@dschaper
Copy link
Member

dschaper commented Nov 28, 2024

This would break the flow, only the environment variable declarations were changed and not where the variables were actually used:

https://github.com/pi-hole/docker-pi-hole/pull/1664/files#diff-c58efb7d239ba7eb89123ff4b9e3117bd84c382787283c3f149cf0c4620d7029L150-L169

And the secrets are actually namespaced to DOCKERHUB, there are no secrets named as proposed in this change.

image

@dschaper dschaper closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants