Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making pololu/dual-vnh5019-motor-shield a dependency #2

Open
photodude opened this issue Jun 14, 2018 · 1 comment
Open

Consider making pololu/dual-vnh5019-motor-shield a dependency #2

photodude opened this issue Jun 14, 2018 · 1 comment

Comments

@photodude
Copy link
Owner

We should consider making pololu/dual-vnh5019-motor-shield a dependency, and this library as a shim (I think that's the right term) for the additional functions

This would rewrite the library

namespace pololu/dual-vnh5019-motor-shield = DualVNH5019MotorShieldMod1;
namespace pololu/dual-vnh5019-motor-shield = DualVNH5019MotorShieldMod2;

core library functions would be parent functions that we pass two sets of parameters to...

There are pros and cons to consider in making this change

@photodude
Copy link
Owner Author

I think the plan here will be to rewrite the library as a new repo and to incorporate pololu/dual-vnh5019-motor-shield as an included dependency. This will mean the new repo will have additional releases to update the pololu/dual-vnh5019-motor-shield as an included dependency.

No Idea if/when I will take on this rewrite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant