Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CARO terms don't have labels #378

Open
hlapp opened this issue Jan 29, 2021 · 0 comments
Open

Some CARO terms don't have labels #378

hlapp opened this issue Jan 29, 2021 · 0 comments

Comments

@hlapp
Copy link
Member

hlapp commented Jan 29, 2021

For example, http://purl.obolibrary.org/obo/CARO_0020004:

$ curl -X GET "https://kb.phenoscape.org/api/term/labels?iris=%5B%22http%3A%2F%2Fpurl.obolibrary.org%2Fobo%2FCARO_0020004%22%5D" -H "accept: application/json"

{"results":[{"@id":"http://purl.obolibrary.org/obo/CARO_0020004","label":null}]}

Is this expected? Note that there are CARO terms that do have labels in the database, so this is at the least quite inconsistent. (It's also throwing off some tests in Rphenoscape that by random sampling occasionally hit a CARO term that doesn't have a label.)

hlapp added a commit to phenoscape/rphenoscape that referenced this issue Feb 2, 2021
Some ontologies, in particular apparently CARO, have labels for terms
in the database only inconsistently. This filters out subsumer terms
that are in those ontologies, and failed to obtain a label. What is
really being tested here are post-compositions, so this shouldn't affect
the subsumers that are post-comps (whether they fail to obtain a label
or not).

Fixes #161. See also phenoscape/phenoscape-kb-services#378.
hlapp added a commit to phenoscape/rphenoscape that referenced this issue Feb 2, 2021
Some ontologies, in particular apparently CARO, have labels for terms
in the database only inconsistently. This filters out subsumer terms
that are in those ontologies, and failed to obtain a label. What is
really being tested here are post-compositions, so this shouldn't affect
the subsumers that are post-comps (whether they fail to obtain a label
or not).

Fixes #161. See also phenoscape/phenoscape-kb-services#378.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant