Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent versions — need a release system #6945

Open
codingthat opened this issue Nov 15, 2024 · 1 comment
Open

Inconsistent versions — need a release system #6945

codingthat opened this issue Nov 15, 2024 · 1 comment
Labels

Comments

@codingthat
Copy link

Hi! The commit currently tagged v4.0.0-beta.1 has a package.json declaring that it's version 3.87.0:

image

Same goes for the console.log output when you first fire up your Phaser game.

--

If you grab the latest commit (as of this writing) on the v4.0.0 branch, package.json says 4.0.0-beta.2 and console.log says "v4.0.0 Beta 1."

Maybe a script that updates the versions everywhere so they're always the same, or getting it directly from package.json so there's only one place to update it? Even still, a script might be good for tagging, so that package.json and the tag always line up, and right after tagging, package.json can be updated with "-next" or something so people on bleeding edge Git know they're between official versions.

@photonstorm
Copy link
Collaborator

It's probably a good idea, but it doesn't happen that often. We would have to read the version from the package and then have a script to modify the Phaser source directly to inject it, because it can't be done at runtime.

The dist files were correct and npm was correct, so it's only the rare few who want to clone and build from the repo itself that would spot this, and those should be working from the branch directly (which will always be between releases). We'll be more careful in future as I appreciate it's confusing in this instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants