Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metadata Import Wizard to use react-router-dom Outlet #1456

Open
joshsadam opened this issue Jan 26, 2023 · 0 comments
Open

Update Metadata Import Wizard to use react-router-dom Outlet #1456

joshsadam opened this issue Jan 26, 2023 · 0 comments
Labels
developer Issues effecting developers of IRIDA, but that aren't user facing

Comments

@joshsadam
Copy link
Contributor

What needs changed?

Currently SampleMetadataImportWizard is wrapped around each route in the sample metadata import.  This causes the page header and the steps to be re-rendered each time the child component needs to be re-rendered.  What needs to happen is that a layout component needs to be created to handle this and instead of wrapping each route, use react-router-dom's component Outlet.  The router in src/main/webapp/resources/js/pages/projects/samples-metadata-import/index.js will need to be re-written to look something like this:

BrowserRouter
  Routes
  	Route element=layout
  		Route element=SampleMetadataImportSelectFile
  		...
  	/Route
  /Routes
/BrouserRouter

Additional information

A good example can be seen from the react-router-dom documentation: https://reactrouter.com/en/main/components/outlet and their example repo: https://github.com/remix-run/react-router/blob/dev/examples/basic/src/App.tsx

@joshsadam joshsadam added the developer Issues effecting developers of IRIDA, but that aren't user facing label Jan 26, 2023
@joshsadam joshsadam mentioned this issue Jan 26, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Issues effecting developers of IRIDA, but that aren't user facing
Projects
None yet
Development

No branches or pull requests

1 participant