Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please move the plugin location from /etc/irida/plugins to the same directory as the irida war is located (or subdir of thereof) #1427

Open
georgemarselis-nvi opened this issue Dec 6, 2022 · 2 comments

Comments

@georgemarselis-nvi
Copy link

Describe your idea for a new feature

What is the feature you would like to see in IRIDA?

I would like to see the plugins removed from /etc/irida/plugins to somewhere under the same directory the irida.war is located (or subdirectory thereof). If you could please move the configuration file in the same directory, it would be awesome.

Describe how you would access this feature?

Where would you interact with this feature? (New pipeline, new button on the project page, REST API, etc.)

during setup and automatic installation of plugins

Additional information

Add any other context, files, or screenshots about the feature request here.

none

Thank you very much!

@apetkau
Copy link
Member

apetkau commented Dec 6, 2022

Thanks for the suggestion.

Note that you can adjust the location of the pipeline plugins already in the /etc/irida/irida.conf file (see https://phac-nml.github.io/irida-documentation/administrator/web/#core-configuration):

pipeline.plugin.path=/etc/irida/plugins

The location of the irida.conf (and web.conf) files is also defined here:

spring.config.import=classpath:/version.properties,\
classpath:/ca/corefacility/bioinformatics/irida/config/filesystem.properties,\
classpath:/ca/corefacility/bioinformatics/irida/config/caching.properties,\
classpath:/ca/corefacility/bioinformatics/irida/config/ontology.properties,\
classpath:/ca/corefacility/bioinformatics/irida/config/workflows.properties,\
classpath:/ca/corefacility/bioinformatics/irida/config/openapi.properties,\
optional:file:/etc/irida/irida.conf[.properties],optional:file:/etc/irida/web.conf[.properties]

I believe that if you just added another string here pointing to another set of files optional:file:/path/to/irida.conf[.properties],optional:file:/path/to/web.conf[.properties] it should load up configuration from those files as well. I think this entire property spring.config.import can be overridden by passing an appropriate option to Tomcat (though I would have to lookup the syntax). Or, you could modify this file in the extracted irida/ directory from the irida.war file that Tomcat makes when first starting up.

However, I realize that this isn't quite what you may have wanted since this isn't done by default and requires configuration adjustments in a few places.

@georgemarselis-nvi
Copy link
Author

georgemarselis-nvi commented Dec 6, 2022

@apetkau thank you for the info, much appreciated!

but yes, it makes sense in my head for a war to create it's own directory structure and configuration outside of /etc , since war are self-contained.

thank you for the reply!

edit: if I can make an additional argument for moving the config with in the tomcat/webapps directory: I can then have multiple versions of irida each talking to their own database. This would be godsent to drag-and-drop new irida installations and upgrades: have ansible create webapps/irida-XX.version/ unzip the war file and apply appropriate configuration parameters: My users are happy cuz they can continue to use the old irida till we can give them the go-ahead to migrate and i am happy because I would not have to drop the existing irida installation while I upgrade.

only thing missing is to figure out how to set the default app for http://www.vetinst.no/irida (so I can change the default version on the fly) but I suspect that has to do with me reading up more about tomcat.)

thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants