Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auditing Active Passwords/Files/URLS to expire them shows expiry page and not the dashboard after expiring a push. #2647

Open
wedowhateverwewant opened this issue Oct 18, 2024 · 1 comment
Labels

Comments

@wedowhateverwewant
Copy link

wedowhateverwewant commented Oct 18, 2024

Checklist

  • [ x] I've searched the project's issues.
  • [x ] I've searched the project's discussions.

❓ Question

This is true for Password, Files, and URL pushes.

When going to the dashboard and going in the audit section for a push to expire it manually , instead of bringing you back to the dashboard it displays this link is expired ( see image) page right after you expire a push. im on the latest version 1.46.3 , using docker compose pwpush/mysql + gateway
image

@pglombardo
Copy link
Owner

Hi @wedowhateverwewant - this is be design with a recent change. It was done in an effort to simplify the code in tandem with the public gateway. For example, if you are accessing a push delivery page from the gateway, there is not audit log to redirect to because in the gateway, the audit log isn't enabled - so I just simplified everything.

Steps like this have to be taken to simplify the code base which results in less bugs and easier maintenance for me with my limited time.

End users never need to be taken back to the audit log and push creators can manually enter the base url to access their dashboard if needed.

I hope I explained this well enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants