-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alpine conversion due to Debian Critical Vulns #534
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for opal-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -1,14 +1,18 @@ | |||
# BUILD STAGE --------------------------------------- | |||
# split this stage to save time and reduce image size | |||
# --------------------------------------------------- | |||
FROM python:3.10-bullseye as BuildStage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @devine12 thanks for the contribution, can you create a folder community inside the docker folder and add there your changes?
We would love to add it but we don't want to break it for people that using this docker and don't want to update their base image (no internet connection etc..)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alternatively, the base image can be a docker build ARG.
Then we can build & publish both for each version
For now making it a draft PR. |
Fixes Issue
Fixes #513
Changes proposed
Changes debian base images to alpine in the dockerfile
Change asyncio.wait to asyncio.gather in the client engine due to continuous restarting.
ddtrace package requires update to install within alpine
Check List (Check all the applicable boxes)