Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ButterKnife Fragment unbinding #26

Open
npace opened this issue Mar 21, 2017 · 4 comments
Open

ButterKnife Fragment unbinding #26

npace opened this issue Mar 21, 2017 · 4 comments
Labels
enhancement help wanted

Comments

@npace
Copy link

npace commented Mar 21, 2017

Hey, shouldn't you call ButterKnife.unbind(unbinder) in your BaseFragment's onDestroyView(..) callback?
@Rainer-Lang
Copy link

Should.

@pedrovgs
Copy link
Owner

It could be a nice improvement 😃

@DmitriyZaitsev
Copy link

DmitriyZaitsev commented Mar 27, 2017 •
edited
Loading

The project uses the old version of ButterKnife (5.1.+) which doesn't have the unbind(unbinder) method.
So, @npace, the answer is no. :)
But I believe, used libraries should be updated to latest versions.

@pedrovgs
Copy link
Owner

We should update the dependency version before adding this improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@npace @DmitriyZaitsev @pedrovgs @Rainer-Lang