Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TcpMessageStreamPooledFactory should not ALWAYS ping pooled connection #101

Open
pedohorse opened this issue Sep 3, 2024 · 0 comments · May be fixed by #46
Open

TcpMessageStreamPooledFactory should not ALWAYS ping pooled connection #101

pedohorse opened this issue Sep 3, 2024 · 0 comments · May be fixed by #46
Assignees
Labels
scheduler issue related to scheduler

Comments

@pedohorse
Copy link
Owner

cached entries are check for validity with ping command.
but this check happens EVERY time send_message is called on client, which, considering bottleneck may be accumulated latency between message servers, may double small message delivery time (and all we have are small messages).

potential solution:

  • introduce last ping time for cached entries and do not ping within a configurable time interval from it.

potential problems:

  • investigate/test how client reacts to lost connections when it's basically returned broken (if not ping-checked) by open_sending_stream (probably it will be fine - there's error catching on every corner)
@pedohorse pedohorse self-assigned this Sep 3, 2024
@pedohorse pedohorse added the scheduler issue related to scheduler label Sep 3, 2024
@pedohorse pedohorse linked a pull request Sep 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scheduler issue related to scheduler
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant