Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap LS4 and LS3 on the BTPS/BTMS to match real mapping. #1262

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Swap LS4 and LS3 on the BTPS/BTMS to match real mapping. #1262

merged 2 commits into from
Jul 26, 2024

Conversation

slactjohnson
Copy link
Contributor

@slactjohnson slactjohnson commented Jul 26, 2024 •
edited
Loading

Description

Fixes a mis-match between LS3 and LS4 in the BTMS/BTPS.

Motivation and Context

Closes #1261

How Has This Been Tested?

Tested on the stages in the laser hall.

Where Has This Been Documented?

This PR.

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive docstrings, including context and API
  • New/changed functions and methods are covered in the test suite where possible
  • Test suite passes locally
  • Test suite passes on GitHub Actions
  • Ran docs/pre-release-notes.sh and created a pre-release documentation page
  • Pre-release docs include context, functional descriptions, and contributors as appropriate

@slactjohnson slactjohnson marked this pull request as ready for review July 26, 2024 19:37
@slactjohnson
Copy link
Contributor Author

The new mapping was verified by @aberges-SLAC in the laser hall.

tangkong
tangkong approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Things like this might be harder to track in Happi without having a huge list of kwargs, but it's something we can do. (re: #1263)

@slactjohnson slactjohnson merged commit c4c2ae8 into pcdshub:master Jul 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangkong tangkong tangkong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BTPS - LS3 and LS4 are Swapped
2 participants
@slactjohnson @tangkong