Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QADC Duplication #1190

Open
slactjohnson opened this issue Nov 16, 2023 · 1 comment · May be fixed by #1294
Open

QADC Duplication #1190

slactjohnson opened this issue Nov 16, 2023 · 1 comment · May be fixed by #1294

Comments

@slactjohnson
Copy link
Contributor

Current Behavior

We have QADC classes defined in two modules: qadc.py and digitizers.py. Oops.

Expected Behavior

The opposite of this.

Suggested Solution

Clear QADC classes from digitizers.py. Need to check for hutches using these classes already beforehand.
@tangkong
Copy link
Contributor

As far as happi knows, there's only one device using a class from pcdsdevices.digitizers (lm1k4_qadc)

And none calling from qadc.py

@slactjohnson slactjohnson linked a pull request Oct 10, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

QADC Update: Background Subtraction, CFD Edge Detection slactjohnson/pcdsdevices
2 participants
@slactjohnson @tangkong