Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_editor to LCLS happi item? #1180

Open
klauer opened this issue Nov 8, 2023 · 2 comments
Open

Add last_editor to LCLS happi item? #1180

klauer opened this issue Nov 8, 2023 · 2 comments

Comments

@klauer
Copy link
Contributor

klauer commented Nov 8, 2023

Context

Container:

class LCLSItem(OphydItem):

device_config keeps track of our changes: https://github.com/pcdshub/device_config/
We open monthly-ish PRs to review changes from the database prior to merging: pcdshub/device_config#44
The date items were changed is recorded, but the associated username is not.
It may be helpful for us to include "who last touched this item" in order to know who to ask when questions arise in that diff.

@tangkong
Copy link
Contributor

tangkong commented Nov 8, 2023

This would also require a commensurate change in happi in order to collect that information.

some digging to save myself some time later, though this should probably show up as an issue in happi: item.save is bound on load (source)

@klauer
Copy link
Contributor Author

klauer commented Nov 8, 2023

Should there be a happi hook for "container to be saved" I wonder?
We can't (or shouldn't) go and change the default HappiItem for this information of course

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants