Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad Error Message Texts in GroupDevice #1087

Open
ZLLentz opened this issue Nov 18, 2022 · 1 comment
Open

Bad Error Message Texts in GroupDevice #1087

ZLLentz opened this issue Nov 18, 2022 · 1 comment

Comments

@ZLLentz
Copy link
Member

ZLLentz commented Nov 18, 2022 •
edited
Loading

Expected Behavior

You should be able to have well-formed error messages when using GroupDevice

Current Behavior

GroupDevice breaks the text in the wait_for_connection error message and probably others that rely on Signal instances having well-defined parent attributes to get proper dotted_name results.

Possible Solution

  • Some systematic way to restore dotted_name in signal components for GroupDevice?
  • Bandaid fixes for specific error messages?

Context

Came up when looking at wait_for_connection error messages in a dev build of happi audit to check which Slits were missing the soon-to-be-added motor PV aliases.

Your Environment

pcds-5.5.1
@tangkong
Copy link
Contributor

The happi audit output in question (now bustling with activity)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZLLentz @tangkong