Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Table,misc): rewrite column management demo, remove old dnd examples #11295

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Nov 27, 2024

Closes #11190.

Also slightly touches up the basic column management demo as the changes to Modal are the same.

There is an issue with DragDropSort I've noticed but haven't yet debugged, that the DataListItems it creates internally are for some reason duplicating the DataListItemControl component for the DataListCheck, giving it extra padding. I'm not sure why this is happening, as it doesn't occur in the DragDropSort DataList example even with the same content code structure.

@patternfly-build
Copy link
Contributor

patternfly-build commented Nov 27, 2024

@tlabaj tlabaj requested review from a team, wise-king-sullyman and tlabaj and removed request for a team December 2, 2024 15:51
@tlabaj
Copy link
Contributor

tlabaj commented Dec 4, 2024

@kmcfaul can you open an issue to track the DragDropSort bug you mention above?

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Dec 4, 2024

Opened #11312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated DragDrop examples and demos
3 participants