Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/api/health endpoint does not actually indicate service health #842

Open
reegnz opened this issue Sep 18, 2024 · 1 comment
Open

/api/health endpoint does not actually indicate service health #842

reegnz opened this issue Sep 18, 2024 · 1 comment

Comments

@reegnz
Copy link

reegnz commented Sep 18, 2024

I've tried integrating policy-bot with kubernetes readyness probes but to no avail.
The health endpoint reports 200 OK very early in the startup process, and the service will keep responding with 504 for several seconds after the health endpoint already reporting 200 OK.

Would be great if the health endpoint would actually indicate whether the service is already up and running.

@bluekeyes
Copy link
Member

Thanks for the report. The behavior you describe is surprising to me, because the last thing Policy Bot does at startup is enable the HTTP server, which serves the /api/health route and all other routes. If you can get a response from /api/health you should be able to get a valid response from any other endpoint.

Are there any more details you can share about the error you are seeing? Would it be possible to share the Kubernetes manifest you are using to deploy the app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants