Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intellij plugin doesn't need IDE restart anymore #416

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

crogoz
Copy link
Contributor

@crogoz crogoz commented Sep 17, 2024

Before this PR

Any update of the palantir-gradle-jdk plugin needed a restart of Intellij.

After this PR

In preparation for #410 (prompting the user to update the version of the plugin), we are making the plugin dynamic (https://plugins.jetbrains.com/docs/intellij/dynamic-plugins.html) such that upgrading the plugin version won't need a restart of the IDE anymore.

==COMMIT_MSG==
Intellij plugin doesn't need IDE restart anymore
==COMMIT_MSG==

Possible downsides?

Not possible to test updating the plugin using ./gradlew runIde. I ran the verification as per https://plugins.jetbrains.com/docs/intellij/dynamic-plugins.html#restrictions & ade sure we are cleaning up all the resources (https://plugins.jetbrains.com/docs/intellij/dynamic-plugins.html#resource-cleanup).

@changelog-app
Copy link

changelog-app bot commented Sep 17, 2024

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Intellij plugin doesn't need IDE restart anymore

Check the box to generate changelog(s)

  • Generate changelog entry

@@ -111,6 +111,7 @@ public void maybeSetupGradleJdks() {
TasksKt.withBackgroundProgress(
project,
"Gradle JDK Setup",
TaskCancellation.nonCancellable(),
Copy link
Contributor Author

@crogoz crogoz Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the user had a button "x" to cancel the background task, but even if they clicked the button nothing would happen until the ./gradle-jdks-setup script finished running.
Now, the button won't be shown anymore.
Screenshot 2024-09-17 at 12 12 05 PM

@bulldozer-bot bulldozer-bot bot merged commit b2221b0 into develop Oct 9, 2024
5 of 6 checks passed
@bulldozer-bot bulldozer-bot bot deleted the cr/disposable branch October 9, 2024 10:43
@autorelease3
Copy link

autorelease3 bot commented Oct 9, 2024

Released 0.49.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants