Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in "Prefer acyclic dependency graphs" section of Java coding principles #2408

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/best-practices/java-coding-guidelines/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -1760,7 +1760,7 @@ public FooResource(String name) {
}
```

Acyclic dependency graphs are hard to understand, hard to setup for tests and mocks, and introduce subtle code ordering
Circular dependency graphs are hard to understand, hard to setup for tests and mocks, and introduce subtle code ordering
constraints. For example, switching the order of the constructor statements introduces a bug where the resource name is
always "FooResource on port 0" since `Server#port` hasn't been initialized when the resource calls `Server#port()`:

Expand Down