Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either deprecate macos support or test it in CI #1267

Open
antoninbas opened this issue Aug 31, 2024 · 1 comment
Open

Either deprecate macos support or test it in CI #1267

antoninbas opened this issue Aug 31, 2024 · 1 comment

Comments

@antoninbas
Copy link
Member

The stuff in https://github.com/p4lang/behavioral-model/tree/main/tools/macos has not been updated (or I assume, tested) in years. We should either:

  1. Add a disclaimer notice to that folder indicating that the scripts are not tested and unlikely to work on recent macOS versions without modification. We should also update the reference to these scripts in the README. It's the easy way out... Or,

  2. Update the scripts and add new Github workflow using the macos runners to validate that dependencies can be installed and bmv2 can build successfully. This could be a lot of work, and be a significant maintenance effort moving forward.

@fruffy
Copy link
Contributor

fruffy commented Aug 31, 2024

Option 2 would be nice since we do have good MacOS support for P4C. Part of the reason support is now easier for P4C is because we control most of the dependency versions with CMake's FetchContent. This reduces the amount of different dependency versions users can realistically have.

Iirc we do not have this with BMv2 other than using third-party for CI. Unclear how much maintenance work this would require.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants