Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inaccessible rooms can leak existance through some 403 (instead of 404) responses #214

Open
jagerman opened this issue Feb 28, 2024 · 0 comments

Comments

@jagerman
Copy link
Member

jagerman commented Feb 28, 2024

(Report received out-of-band from a user unwilling to use Github):

From the docs (and our intention):

404 Not Found — Returned if the room does not exist, or is configured as inaccessible (and this user doesn't have access)."

And to a larger extent, the return of a 404 when actions are performed on rooms with all permissions disabled.

From a cursory check, it seems that both a manual "accessible" check and an @auth.accessible_required decorator are missing from several routes in rooms.py, messages.py and views.py, potentially allowing a user to scan for existing room names.

The web viewer, for instance, returns 403 instead of 404 for an inaccessible room.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant