Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Prometheus metrics #83

Open
orishoshan opened this issue Sep 25, 2023 · 2 comments
Open

Support Prometheus metrics #83

orishoshan opened this issue Sep 25, 2023 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@orishoshan
Copy link
Contributor

Today, only the network-mapper exposes Prometheus metrics (default Golang metrics as well as custom metrics).

Proposal: Expose Prometheus default Golang metrics as well as custom metrics, such as secret created, updated, and so on.

@orishoshan orishoshan added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 25, 2023
@srijan-keshri
Copy link

Can I try this? Also, can you specify all the required metrics that need to be added?

Additionally, can you clarify in which file we create and update the secret? I tried to find out, but I found the logs in both managers.go as well as base.go files. I will also be going through the codebase thoroughly.

@orishoshan
Copy link
Contributor Author

Hey @srijan-keshri, of course! This issue was created at a time when the credentials operator had only one set of secrets, but now it's a lot more mature :) How about we start with just the default Golang metrics, and in the meantime we'll work on compiling a list of all other metrics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants