-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MediaStream 'ended' event deprecation #19
Comments
@fippo Do you think dropping I would like to work on a new version because of the above issue. It could be a new major... |
away with webrtcsupport... |
and what about |
In Chrome 62, in Screen Share, the 'ended' event is not firing. Line 153 of localmedia.js, is never called. Any thoughts on workarounds? |
If you click on the system popup which typcially reads: "... is sharing a window .. Stop Sharing/Hide", it works. If the user clicks on a button and you call stopScreenShare(), it doesn't work. The first fix I have done is to just add another function to detect chrome 62 next to the FireFox fix. That seems to work. Though, it is not satisfying. |
@samsont if you call stopScreenShare and that calls track.stop() then track.onended will not be called. That is a general design principle for those event handlers. It should not have changed in Chrome 62 though. |
I agree. My memory is that track.onended is not called. But, the event 'ended' is generated. And, we are still using that event in this code. It works pretty well for disconnecting streams and the like. It even works for screenshare when using the system popup to stop the screenshare. But, hitting a button and telling it to stop no longer works. Do you have any ideas for replacements for looking for the 'ended' event? In chrome 62, there is a small note about background video track optimization using media extensions. https://developers.google.com/web/updates/2017/09/chrome-62-media-updates. I don't think it is related -- but it might be. |
I've just run into this:
The MediaStream 'ended' event is deprecated and will be removed in M53, around September 2016. Please use the MediaStream 'inactive' event instead. See https://www.chromestatus.com/features/5730404371791872 for more details.
Do you have any idea how to proceed?
Regarding to firefox:
cd51391
how can i help?
The text was updated successfully, but these errors were encountered: