New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Statsgrid fixes #2750

Merged

ZakarFin merged 3 commits into oskariorg:develop from okauppinen:statsgrid-fixes

Nov 27, 2024

Contributor

okauppinen commented Nov 27, 2024

set loading after data exists check to avoid neverending spinner (no valid data for saving)
create copy from seletor to avoid messing up cached object (could be fixed by returning deep cloned object)
don't add error if metadata selector is missing. Fixes issue where every single indicator doesn't have all multi indicator selections. Indicator is added with valid/allowed selections.

okauppinen added 3 commits

November 27, 2024 12:12


          set loading after data exists check

e937a23


          create copy from seletor

1678a94


          don't add error if metadata selector is missing

61c97aa

ZakarFin added this to the 2.14.0 milestone

ZakarFin merged commit 6ff8b36 into oskariorg:develop

1 check passed

okauppinen deleted the statsgrid-fixes branch

November 27, 2024 20:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet