-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow WFS search channels to set region based on property #280
Comments
Sounds good. I would make the |
Right, then I think we should split the work in three separate parts
Each part could be added separately and each provide extra value. |
And maybe part 4 as an optional external source for codelists that can also be added later on. In part 3 I would like to keep the value mapping/codelists out of OskariWFSClient and instead make the client aware of the mapping. So getting features from the service would return the actual values and mapping codes to user-friendly values would be done on the UI. |
There's an action route that is used to fetch coverage data for layers etc. The same route could be extended and used to pass the codelists to frontend for vector sources: https://github.com/oskariorg/oskari-server/blob/master/control-base/src/main/java/org/oskari/control/layer/DescribeLayerHandler.java |
I'll implement |
@jampukka like the other issue I just commented on: what's the situation with this? You made a PR on 2022 with the mention on this but is there still something you'd like the Oskari team to work on? If you wish to keep this open and get updates, please create a new issue here: https://github.com/oskariorg/oskari-documentation/issues |
Currently single fixed value can be configured as the value for
region
per WFS search channel (https://github.com/oskariorg/oskari-server/blob/2.8.1/service-search-wfs/src/main/java/fi/nls/oskari/search/channel/WFSSearchChannel.java#L112). We should extend this to allow admin to configure a property to be used for extractingregion
from a Feature.In addition I propose we allow providing simple (possibly even localized in the future) mapping configuration to optionally alter the value. This could be used to for example map municipality codes (
091
) to human readable region names (Helsinki
).The text was updated successfully, but these errors were encountered: