-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Setup and Start shell scripts for a virtual Python environment on Linux, add EOX with 2021 images as provider #248
base: master
Are you sure you want to change the base?
Conversation
Self contained O4XP install is a genial idea, especially when running and testing several versions of O4XP - thank you! System GDAL is not visible in venv. $PWD is a bit different on Arch idna, charset-normalizer, urllib, certifi are installed automatically by pip, as dependency of requests. Chardet is deprecated, if I understand correctly (replaced by charset-normalizer) |
2 scripts with complete install of Ortho4XP 1.40 for macOS. Python 11 and Python 12 version.
Works also on Ubuntu, with system packages installed as per Install_Instructions.txt
z_Install_Python_Venv.sh
Outdated
|
||
# 4. Download scikit-fmm's "meson" branch, compile and install it | ||
|
||
git clone --branch meson https://github.com/scikit-fmm/scikit-fmm.git $path/scikit-fmm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't necessary as there is a package on pypi that seems to do the trick.
I've just been looking at making the local process a bit more self contained but stumbled across your PR as I was about to submit one.
Via Python 3.11, here's the list of requirements that I was going to submit in a PR. Note that Rtree
has been updated as the version referenced by Ortho4XP doesn't include a required DLL. sckit-fmm is also referenced.
certifi==2024.2.2
chardet==5.2.0
charset-normalizer==3.3.2
idna==3.7
numpy==1.26.4
pillow==10.3.0
pyproj==3.6.1
requests==2.31.0
Rtree==1.2.0
scikit-fmm==2023.4.2
shapely==2.0.4
urllib3==2.2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is absoluttely necessary on Python 3.12 on Arch and one of the very reasons why I wrote the script in the first place.
@@ -0,0 +1,11 @@ | |||
certifi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depending on the thoughts of the developer/maintainer, I think it's best to version lock this and to replace the existing requirements file as otherwise both files will have to be maintained. This file will eventually fall out of sync as soon as a package makes a breaking change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm against version locking by default. If a package makes a breaking change, the particular requirement can still be version locked. Besides, I don't see no harm in two requirements files.
But I'm not trying to get the entire PR merged anyway. It's just here for Oscar's consideration and cherry picking changes.
scikit-fmm for python 3.12 has been released. Use: pip install scikit-fmm. |
If I understand correctly, it is still compiled from source - by pip install. |
Scikit-fmm installs from pip without issues for me now. I've updated the script and requirements accordingly. |
Derived from PR oscarpilote#248
This adds: