Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water Mask creating error #249

Open
emiliovfx opened this issue May 4, 2024 · 1 comment
Open

Water Mask creating error #249

emiliovfx opened this issue May 4, 2024 · 1 comment
Labels

Comments

@emiliovfx
Copy link

Hello. Great job with the update of ortho4XP for the new XP12 terrain format.

Most of the tiles I already converted from the old XP11 are working fine, except one, where an error is hanging the water mask creation process.

Here is the error.

Exception in thread Thread-7 (build_masks):
Traceback (most recent call last):
  File "C:\Python311\Lib\threading.py", line 1045, in _bootstrap_inner
    self.run()
  File "C:\Python311\Lib\threading.py", line 982, in run
    self._target(*self._args, **self._kwargs)
  File "G:\Ortho4XP-master\1.4\Ortho4XP-master\Ortho4XP-master\src\O4_Mask_Utils.py", line 119, in build_masks
    (dico_sea, dico_inland) = record_water_tris(tile, )
                              ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "G:\Ortho4XP-master\1.4\Ortho4XP-master\Ortho4XP-master\src\O4_Mask_Utils.py", line 453, in record_water_tris
    pt_in[5 * i + 3 : 5 * i + 5] = [
    ~~~~~^^^^^^^^^^^^^^^^^^^^^^^
ValueError: could not broadcast input array from shape (0,) into shape (2,)

The mesh is looking good.

image

Here is a link to download the generated mesh where the problem of creating the water masks is happening.

https://www.dropbox.com/scl/fi/krli5q5neo7hwj8xwql0g/zOrtho4XP_-17-102.zip?rlkey=nezw3f3s02iga5kob5mc2eo1p&dl=1

The water masks creation process in o4xp 1.3 is working well.

I hope this helps to debug this error.

@emiliovfx
Copy link
Author

I found the issue. It hangs when reading adjacent tiles info, probably when defining the border mask edges.

I removed the adjacent tiles and o4xp was able to generate the masks for the specific tile.

@d41k4n d41k4n added the bug label May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants