Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'type' property to package.json #661

Closed
wants to merge 1 commit into from

Conversation

fnschmidt
Copy link

Otherwise, Node 20.x considers to be a CommonJS module
Fixes #660

Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cookieconsent-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 6:25pm

Copy link

netlify bot commented Mar 17, 2024

Deploy Preview for cookieconsentv3-playground ready!

Name Link
🔨 Latest commit 50f575c
🔍 Latest deploy log https://app.netlify.com/sites/cookieconsentv3-playground/deploys/65f735823396490008ede22c
😎 Deploy Preview https://deploy-preview-661--cookieconsentv3-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@orestbida
Copy link
Owner

@greybaron this change breaks all tests

@fnschmidt
Copy link
Author

Then this should be closed, I am inexperienced in regard to npm packaging. Still don't know why my setup requires this key to be set.

@orestbida
Copy link
Owner

Closing this. See my comment here.

@orestbida orestbida closed this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 'type' declaration inside package.json is missing, causing it to be considered a CommonJS module
2 participants