Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View title is empty when using Peaberry GuiceExtensionFactory #59

Open
mcculls opened this issue Jun 22, 2015 · 2 comments
Open

View title is empty when using Peaberry GuiceExtensionFactory #59

mcculls opened this issue Jun 22, 2015 · 2 comments

Comments

@mcculls
Copy link
Member

mcculls commented Jun 22, 2015

Originally reported on Google Code with ID 56

What steps will reproduce the problem?
1. Use the GuiceExtensionFactory for an existing View to be able to inject OSGi service
2. Run application
3. The title of the view is empty, even though the "name" is specified in the view
extension, like this:

   <extension
         point="org.eclipse.ui.views">
      <view
            class="org.ops4j.peaberry.eclipse.GuiceExtensionFactory:productview.ProductView"
            id="productview.ProductView"
            name="Product View">
      </view>
   </extension>


A workaround seems to be to use setPartName("Product View") in ProductView.createPartControl.

Why does this happen?

Reported by aforsell1971 on 2011-03-29 22:19:50

@mcculls
Copy link
Member Author

mcculls commented Jun 22, 2015

GuiceExtensionFactory delegates to the Eclipse ExtensionRegistry "createExecutableExtension"
method, which should pass on the configuration to the instance. Does this only happen
when you prefix the factory class? If so then a simple testcase would be helpful.

Reported by mcculls on 2011-04-03 21:46:32

@mcculls
Copy link
Member Author

mcculls commented Jun 22, 2015

Reported by mcculls on 2012-08-04 21:41:05

  • Labels added: Peaberry-Extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant