NO-JIRA: ci: Use 'centos-release' package to detect if we are testing CentOS Stream #1448
Conversation
…tream Until openshift#1237 is resolved, we need to skip Secure Boot tests for CentOS Stream based variants. As we now use CentOS Stream packages for other variants than the `scos` one for pre-testing, we can not rely on the variant name and instead have to look at the list of included packages to differentiate between RHEL and CentOS Stream based builds.
travier
changed the title
openshift-ci
bot
added
the
approved
travier
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@travier: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
Secure Boot tests are now skipped in the CI based on wether or not we are using CentOS Stream content.
|
Updated to take into account kola test snooze that expired. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbtrystram, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@travier: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| variant="default" | ||
| fi | ||
| if [[ "${variant}" != "scos" ]]; then | ||
| if rpm-ostree compose tree --print-only "${manifest}" | jq -r '.packages[]' | grep -q "centos-release"; then |
There was a problem hiding this comment.
This logic looks inverted. If centos-release is present then we need to skip Secure Boot tests, not the other way around.
I think the reason this passed CI is that this condition happened to fail on another error, which is that manifest is not defined:
/src/ci/prow-entrypoint.sh: line 126: manifest: unbound variable
And I think the reason set -e didn't kick in here is likely a combination of it being in an if-statement and piping things.
There was a problem hiding this comment.
Arg, thanks for noticing
ci: Use 'centos-release' package to detect if we are testing CentOS Stream
Until #1237 is resolved, we need
to skip Secure Boot tests for CentOS Stream based variants.
As we now use CentOS Stream packages for other variants than the
scosone for pre-testing, we can not rely on the variant name and instead
have to look at the list of included packages to differentiate between
RHEL and CentOS Stream based builds.
kola-denylist: Do not snooze basic tests anymore
Secure Boot tests are now skipped in the CI based on wether or not we
are using CentOS Stream content.
kola-denylist: Update RHCOS 9.4 snooze dates
kola-denylist: Use uniform identing
kola-denylist: Regroup test snooze by variant