Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transition oc adm release new metadata for operating systems #1047

Open
cgwalters opened this issue Nov 1, 2022 · 2 comments
Open

transition oc adm release new metadata for operating systems #1047

cgwalters opened this issue Nov 1, 2022 · 2 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@cgwalters
Copy link
Member

See coreos/coreos-assembler#3153 (comment)

Basically, we should rework oc adm release new to natively search for ostree-container images, instead of having this machine-os thing. Further, I think we should suppport multiple in the release image.

Then we can drop the OCP-specific metadata on the container.
@cgwalters cgwalters mentioned this issue Nov 1, 2022
Merged
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 31, 2023
@travier
Copy link
Member

travier commented Feb 9, 2023

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 9, 2023
jlebon added a commit to jlebon/os that referenced this issue Sep 27, 2023
@jlebon
Re-enable ostree-container-inject-openshift-cvo-labels knob
32e890c 
This was previously enabled (openshift#1048) and then disabled again (openshift#1084)
because `oc` doesn't know how to handle multiple images with those
labels in the release payload. We'll need to solve this eventually if
we want to be able to ship multiple OS images in the payload (that's
tracked in openshift#1047), but we don't need to block on this if we can remove
the legacy `machine-os-content` at the same time.

See also: openshift/driver-toolkit#101
See also: openshift/machine-config-operator#3364
@jlebon jlebon mentioned this issue Sep 27, 2023
Merged
jlebon added a commit to jlebon/os that referenced this issue Sep 27, 2023
@jlebon
Re-enable ostree-container-inject-openshift-cvo-labels knob
12a9a69 
This was previously enabled (openshift#1048) and then disabled again (openshift#1084)
because `oc` doesn't know how to handle multiple images with those
labels in the release payload. We'll need to solve this eventually if
we want to be able to ship multiple OS images in the payload (that's
tracked in openshift#1047), but we don't need to block on this if we can remove
the legacy `machine-os-content` at the same time.

See also: openshift/driver-toolkit#101
See also: openshift/machine-config-operator#3364
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cgwalters @openshift-bot @travier