Stop pulling in machine-os-content
#102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of https://github.com/openshift/enhancements/blob/master/enhancements/ocp-coreos-layering/ocp-coreos-layering.md we have switched to a new `rhel-coreos-8`. Really, nothing else besides the MCO should be pulling in or referencing the OS images. I don't understand what cross-checking the image stream tag was ever doing at all. The MCO owns rolling out the right OS version, and if that isn't correct something else went seriously wrong. Closes: openshift#101
|
/lgtm |
|
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bthurber, cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
qbarrand
added a commit
to qbarrand/driver-toolkit
that referenced
this pull request
Oct 11, 2022
This reverts commit d059f65.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Oct 11, 2022
This reverts commit d059f65.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of https://github.com/openshift/enhancements/blob/master/enhancements/ocp-coreos-layering/ocp-coreos-layering.md we have switched to a new
rhel-coreos-8.Really, nothing else besides the MCO should be pulling in or referencing the OS images. I don't understand what cross-checking the image stream tag was ever doing at all. The MCO owns rolling out the right OS version, and if that isn't correct something else went seriously wrong.
Closes: #101