Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.15] Disable syft github-actions-usage-cataloger #1005

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

creydr
Copy link
Member

@creydr creydr commented Dec 12, 2024

In Konflux we see in the release pipelines the push-rpm-data-to-pyxis task failing due to:

[push-rpm-data-to-pyxis] Uploading RPM data to Pyxis for IMAGE: 674ef915ae22408fb8de8780 with SBOM: 674ef915ae22408fb8de8780.json using script: upload_rpm_data_cyclonedx
[push-rpm-data-to-pyxis] Uploading RPM data to Pyxis for IMAGE: 674ef922ae22408fb8de87b7 with SBOM: 674ef922ae22408fb8de87b7.json using script: upload_rpm_data_cyclonedx
[push-rpm-data-to-pyxis] Uploading RPM data to Pyxis for IMAGE: 674ef92bae22408fb8de87c4 with SBOM: 674ef92bae22408fb8de87c4.json using script: upload_rpm_data_cyclonedx
[push-rpm-data-to-pyxis] Uploading RPM data to Pyxis for IMAGE: 674ef934ae22408fb8de87e2 with SBOM: 674ef934ae22408fb8de87e2.json using script: upload_rpm_data_cyclonedx
[push-rpm-data-to-pyxis] Waiting for the current batch of background processes to finish
[push-rpm-data-to-pyxis] Error: upload of rpm data failed for one of the images
[push-rpm-data-to-pyxis] Error: upload of rpm data failed for one of the images
[push-rpm-data-to-pyxis] Error: upload of rpm data failed for one of the images
[push-rpm-data-to-pyxis] Error: upload of rpm data failed for one of the images
[push-rpm-data-to-pyxis] 
[push-rpm-data-to-pyxis] Printing outputs for current upload_rpm_data script runs
[push-rpm-data-to-pyxis] === 674ef915ae22408fb8de8780 ===
[push-rpm-data-to-pyxis] 2024-12-05 10:42:07,780 [upload_rpm_data] DEBUG Image ID: 674ef915ae22408fb8de8780
[push-rpm-data-to-pyxis] 2024-12-05 10:42:07,780 [upload_rpm_data] DEBUG Pyxis GraphQL API: https://graphql-pyxis.preprod.api.redhat.com/graphql/
[push-rpm-data-to-pyxis] 2024-12-05 10:42:07,795 [upload_rpm_data] INFO Loaded 3096 components from sbom file.
[push-rpm-data-to-pyxis] Traceback (most recent call last):
[push-rpm-data-to-pyxis]   File "/home/pyxis/upload_rpm_data_cyclonedx", line 321, in <module>
[push-rpm-data-to-pyxis]     main()
[push-rpm-data-to-pyxis]   File "/home/pyxis/upload_rpm_data_cyclonedx", line 315, in main
[push-rpm-data-to-pyxis]     upload_container_rpm_data_with_retry(args.pyxis_graphql_api, image_id, args.sbom_path)
[push-rpm-data-to-pyxis]   File "/home/pyxis/upload_rpm_data_cyclonedx", line 49, in upload_container_rpm_data_with_retry
[push-rpm-data-to-pyxis]     upload_container_rpm_data(graphql_api, image_id, sbom_path)
[push-rpm-data-to-pyxis]   File "/home/pyxis/upload_rpm_data_cyclonedx", line 70, in upload_container_rpm_data
[push-rpm-data-to-pyxis]     rpms, content_sets = construct_rpm_items_and_content_sets(sbom_components)
[push-rpm-data-to-pyxis]   File "/home/pyxis/upload_rpm_data_cyclonedx", line 259, in construct_rpm_items_and_content_sets
[push-rpm-data-to-pyxis]     purl_dict = PackageURL.from_string(component["purl"]).to_dict()
[push-rpm-data-to-pyxis]   File "/usr/local/lib/python3.9/site-packages/packageurl/__init__.py", line 508, in from_string
[push-rpm-data-to-pyxis]     raise ValueError(msg)
[push-rpm-data-to-pyxis] ValueError: Invalid purl 'pkg:github/docker:/#docker.mirror.hashicorp.services/rhysd/actionlint:latest' cannot contain a "user:pass@host:port" URL Authority component: ''.

According to the discussion in https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1733406819412889, we need to disable the github-actions-usage-cataloger syft cataloger for the func-utils Konflux component.

@creydr
Copy link
Member Author

creydr commented Dec 12, 2024

@dsimansk @matejvasek could you PTAL?
Alternatively we could also add a custom task to the pipeline, which creates this file. But I am not sure how complex this is with the oci-ta pipelines, so I selected this path.

@creydr
Copy link
Member Author

creydr commented Dec 12, 2024

/cherry-pick release-v1.16

@openshift-cherrypick-robot

@creydr: once the present PR merges, I will cherry-pick it on top of release-v1.16 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@creydr
Copy link
Member Author

creydr commented Dec 12, 2024

/cherry-pick main

@openshift-cherrypick-robot

@creydr: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Collaborator

/approve
/lgtm

@matejvasek
Copy link
Collaborator

/lgtm
/approve

Copy link

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dsimansk, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Dec 12, 2024

No need to wait on prow with this

@creydr creydr merged commit 6242c15 into openshift-knative:release-v1.15 Dec 12, 2024
30 of 34 checks passed
@openshift-cherrypick-robot

@creydr: new pull request created: #1006

In response to this:

/cherry-pick release-v1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@creydr: new pull request created: #1007

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants