Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wb_ack_o missing in wb_to_avalon_bridge for BURST_SUPPORT = 0 #108

Open
AakaFosfor opened this issue Oct 28, 2016 · 4 comments
Open

wb_ack_o missing in wb_to_avalon_bridge for BURST_SUPPORT = 0 #108

AakaFosfor opened this issue Oct 28, 2016 · 4 comments

Comments

@AakaFosfor
Copy link

The core wb_to_avalon_bridge doesn't work when the burst support is not selected - there is no assignment for the wb_ack_o signal.

@olofk
Copy link
Member

olofk commented Nov 8, 2016

Hi,

Just wanted to let you know that I've seen the issue, but unfortunately I don't know enough about that core to give you an answer right away, and I haven't had time to look into it either

@AakaFosfor
Copy link
Author

Hi, thanks for letting me know. No direct problem for me, I have finally used another core (simplified version I found my colleague already did for the same situation I wanted to used it in). So the issue is just FYI. Theoretically, WB-Avalon crossing should be quite easy (so the patch), but I didn't work with Avalon before, so I don't dare to propose a correction.

@skristiansson
Copy link
Member

I'm not sure I understand, AFAICT 'wb_ack_o' is assigned at https://github.com/openrisc/orpsoc-cores/blob/master/cores/wb_avalon_bridge/verilog/wb_to_avalon_bridge.v#L231 when BURST_SUPPORT == 0. What am I missing?

@AakaFosfor
Copy link
Author

You are right, thank you for pointing it out. I missed "generate-else" at line 214. So the red X in my simulation had to be caused by something else... So, sorry for this issue, you can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants