Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download openHAB 4.0.0 SNAPSHOT Add-ons" suggests wrong name #405

Open
spacemanspiff2007 opened this issue May 22, 2023 · 6 comments
Open
Assignees

Comments

@spacemanspiff2007
Copy link

Under download select the following

grafik

Then click on

grafik

Filename has the wrong extension "mid" instead of "kar"

grafik

@kaikreuzer
Copy link
Member

Are you sure that your browser isn't doing any fancy stuff?

When I click this button, it is correctly downloading the kar (with this name):

Bildschirmfoto 2023-05-22 um 18 25 45

@spacemanspiff2007
Copy link
Author

The link shows the same for me but in the dialog it changes to .mid.

grafik

Are you sure that your browser isn't doing any fancy stuff?

That's absolutely possible. I am using the latest Firefox on Win10.
I do download the snapshots quite often and every time I manually edit the suffix in the dialog yet it pops up again with .mid.

Would it be possible to use the download attribute for the link?
That way the filename could be explicitly passed to the browser.

If not and if I am the only one who is having this behavior this issue can be closed.

kaikreuzer added a commit that referenced this issue May 25, 2023
@kaikreuzer
Copy link
Member

I have created #407 for it.
You can test on https://deploy-preview-407--openhab.netlify.app/download/ whether this resolves the issue for you.

@spacemanspiff2007
Copy link
Author

grafik

After the download there has to be a "=" with the filename - I've left a comment.

@Confectrician Confectrician self-assigned this Jun 2, 2023
@Confectrician
Copy link
Contributor

I will take care of the naming part, when #407 has been merged.

@kaikreuzer
Copy link
Member

@Confectrician Thanks a lot - go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants