Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search returns incomplete results #140

Open
LightIsLife opened this issue Jan 4, 2019 · 6 comments
Open

Search returns incomplete results #140

LightIsLife opened this issue Jan 4, 2019 · 6 comments

Comments

@LightIsLife
Copy link

Just noticed that searching the docs for "Profile" does not deliver the link where this new concept is explained. Using the search function, I was expecting to find this link: https://www.openhab.org/docs/configuration/items.html#profiles

However, this link was not returned by the search, see screenshot below:
screen shot 2018-12-31 at 10 10 02 am

@ghys
Copy link
Member

ghys commented Jan 4, 2019

Indeed. My guess is it's simply not prominent enough yet to have a good ranking in the index. I don't know nor control how Algolia works in this matter. Maybe @Shipow or @s-pace can provide more insight.

But I can confirm this paragrapg is indeed indexed because searching for "built-in profiles" or "profiles specified" or "rawbutton-toggle-switch" returns results.
I don't have a good miracle suggestion, maybe the title should be changed to "Defining Profiles" or something similar.

@s-pace
Copy link

s-pace commented Jan 5, 2019

👋 @LightIsLife,
@ghys has well described the situation here. The level of the word you are looking for is wrapped in a <h4/> tag, that is to say a lvl5 in your DocSearch hierarchy defined by your configuration. While the current most popular result here is wrapped in a <h2/> tag, that is to say a lvl2 in the DocSearch hierarchy. This is why it is ranked higher.

The expected record is indexed but ignored missing because, by default, we only display the top 5 best records.

You can change the HTML tag wrapping the expected record of your website or you can also change the hitsPerPage parameter from the DocSearch JS snippet included in your page.

@Confectrician
Copy link
Contributor

Thanks for this well explanation. :)

@LightIsLife
Copy link
Author

Thanks all, much appreciated and I learned a lot.
As a user experience, however, this begs the question of utility. "Profiles" have been recently introduced as a new and exciting concept.....but I cannot find them easily in the docs...they are not listed on the sidebar....and the search function turns up nothing. I am sure I am not the only one frustrated by this.
Honestly, I am rather dealing with more returns that not finding what I am looking for. Right now, it is not apparent for the user that the search results are deliberately limited to the top 5.....again, as an end-user, I simply would take away that it is not the docs.
Can we not offer the top, say, 10-20 results....5 is just not cutting it.

@Confectrician
Copy link
Contributor

Hey @LightIsLife,

Of course this is a valuable point.
We introduced algolia a short time ago and so it is possible that we have to adapt the settings.
I think this will not be the last time, we have to edit something.

I think 10 results should be a good compromise.
More content and still a dropdown that is not too big.

@ghys
Copy link
Member

ghys commented Jan 5, 2019

As long as it's still ok on phones and so on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants