Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in TSML conceptual paper 15-043r3 #8

Open
phersh2 opened this issue Oct 15, 2024 · 0 comments
Open

Errors in TSML conceptual paper 15-043r3 #8

phersh2 opened this issue Oct 15, 2024 · 0 comments

Comments

@phersh2
Copy link
Contributor

phersh2 commented Oct 15, 2024

  1. Definition of discrete for spatial vs temporal component of a time series.

Does this sentence read better, the second one, where I added bold text?

An OM_Observation whose result is a discrete coverage that varies in time (c.f. OM_DiscreteCoverageObservation). Here the OM_Observation feature type provides the spatio-temporal context for the whole timeseries.

An OM_Observation whose result is a discrete coverage with respect to space, but varies in time (c.f. OM_DiscreteCoverageObservation). Here the OM_Observation feature type provides the spatio-temporal context for the whole timeseries.

Neither! ;) OM_Observation no longer exists, just Observation.

If anything, I'd replace as follows:
An OMS Observation whose result is a discrete coverage that varies in time (c.f. OM_DiscreteCoverageObservation) but not necessarily in space. Here the OMS Observation feature type provides the spatio-temporal context for the whole timeseries.

No specialized DiscreteCoverageObservation, we should probably define a soft-type for what we need.

Does this help?

  1. Change:

The MonitoringFeature serves as the feature of interest for timeseries observations. It extends SF_SpatialSamplingFeature. The geometry of the MonitoringFeature is described by the 'shape' property. For timeseries observations the shape is frequently a point but may be an area polygon or other geometric object.

To

The MonitoringFeature can serve as the feature of interest for timeseries observations. It extends SF_SpatialSamplingFeature. The geometry of the MonitoringFeature is described by the 'shape' property. For timeseries observations the shape is frequently a point but may be an area polygon or other geometric object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant