-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft, Core Sensing and OM Extension #179
Conversation
…ction headings, improved readability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fist half of my review
==== | ||
|
||
[#thing-properties,reftext='{table-caption} {counter:table-num}'] | ||
.Properties of a Thing entity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since id
is just a normal property, it should be listed.
We also need to mention that id
is not editable and usually server generated, but a server may allow client specified ids.
Should be annotated with Computed
or ComputedDefaultValue
from https://github.com/oasis-tcs/odata-vocabularies/blob/main/vocabularies/Org.OData.Core.V1.md
| *Entity Name* | *Role* | *Multiplicity* | *Description* | ||
| `Location` | Locations | Many optional to many optional | The Location entity locates the Thing. Multiple Things MAY be located at the same Location. A Thing MAY not have a Location. A Thing SHOULD have only one Location. | ||
|
||
However, in some complex use cases, a Thing MAY have more than one Location representations. In such case, the Thing MAY have more than one Locations. These Locations SHALL have different encodingTypes and the encodingTypes SHOULD be in different spaces (e.g., one encodingType in Geometrical space and one encodingType in Topological space). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure on the forced different encodingTypes. We have a usecase with each Thing having multiple resolutions of the same shape, all in the same encodingType and in the same space:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting because I just copied this section from 18-088 actually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good reason to change it :)
I'll put it on the agenda for today.
I noticed you accidentally pushed to the 23-019 branch instead of this feature branch, so I reset the 23-019 branch back. I think we can just squash & merge this PR, so we can fix any issues with smaller PRs |
Metanorma build is not working yet, the PR is raised only for the content review