-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discussing the importance of 3D structure and stereochemistry #225
Comments
If you have 3D coordinates, you also have the stereochemistry. So, it's sufficient to just check that the coordinates are 3D (at least within the OpenEye tools, this means you have everything you need...). I'm not aware of specific "tools" where this is a problem, but, as I see it, it's a workflow issue -- if you put together a workflow that generates a molecule from some source, then tries to assign force field parameters and use it in a simulation, it's not going to make any sense to do so if the molecule isn't 3D. Specific places where this should fail: Also, charging molecules that don't have 3D geometries should fail, but that's basically covered under (a) and (b). Basically, what I'm saying is that people will try to put molecules in from all sorts of origins, with and without 3D geometries, and we should stop them from shoving them through without 3D geometries, or what they will get later will make no sense and waste a lot of time. |
@bannanc - did that answer your question? Was there a specific problem we need to solve? Perhaps we should be updating the code to check for 3D coordinates before proceeding? |
@davidlmobley |
Did we find a way to check for 3D coordinates with openeye? I was google searching for a way to do it and this was about the 4th result. |
Yes. |
In issue #223 I introduced concerns about lacking 3-dimensional structures. The actual issue is that when you do a SMARTS or SMIRKS search on molecules without specified stereochemistry it complains with a warning (not an error) such as the one shown below.
It seems to be an issue with ambiguous stereochemistry and not just 3D coordinates. Although if it has 3D coordinates shouldn't that take care of the stereochemistry? Should we be checking for coordinates or specified stereochemistry? What tools is that important for?
The text was updated successfully, but these errors were encountered: