-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0070] rendering library content in unit page #35785
base: master
Are you sure you want to change the base?
feat: [FC-0070] rendering library content in unit page #35785
Conversation
Thanks for the pull request, @ihor-romaniuk! What's next?Please work through the following steps to get your changes ready for engineering review: π Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
π Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
π Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. π Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
π‘ As a result it may take up to several weeks or months to complete a review and merge your PR. |
ea6c563
to
7e3ef8a
Compare
7e3ef8a
to
41a4092
Compare
Testing instructions are missing a rebuild of static assets. This PR didn't work for me until I ran |
{ | ||
type: 'handleViewXBlockContent', | ||
payload: { | ||
destination: event.currentTarget.href || '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if we can also send the usageId
as a separate parameter in the payload here, instead of making the MFE parse it (const newUnitId = payload.destination.split('/').pop()
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. We can simplify payload data and reduce extra calculation on the MFE side.
320fc9a
to
e358489
Compare
e358489
to
4a13e33
Compare
4a13e33
to
84df7ac
Compare
π¨ Dependencies:
Description
This feature introduces functionalities to improve XBlock interactions within iframes:
Unit_Library_Content.mov
Related Pull Requests
Testing instructions
Note: The change requires rebuilding static assets with
tutor dev exec lms opensx-assets build --env=dev