Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename StreamValue to FloatStream #2750

Open
linas opened this issue Aug 8, 2020 · 4 comments
Open

rename StreamValue to FloatStream #2750

linas opened this issue Aug 8, 2020 · 4 comments
Labels
atomspace good first issue Good for newcomers

Comments

@linas
Copy link
Member

linas commented Aug 8, 2020

Per discussion in #2743 this class is mis-named.

Also, rename LinkStreamValue to just plain LinkStream.
@linas linas added atomspace good first issue Good for newcomers labels Aug 8, 2020
@linas linas mentioned this issue Aug 8, 2020
Closed
@Syntactual
Copy link

Can I take this bug?

@linas
Copy link
Member Author

linas commented Aug 11, 2020

Can I take this bug?

Sure, if you promise to think about it so that the grand-total results look like a consistent naming scheme. I think it's mostly all there ...

@Syntactual
Copy link

Sure; this is my first time in the code base so its going to take some time for me to get my bearings. Are you good with that?

@linas
Copy link
Member Author

linas commented Aug 11, 2020

There's no hurry. At a certain level, this task is almost trivial... the hardest part is to also update atom_types.script to match and even that should be easy. I'm just saying .. maybe there is something else that needs renaming, to be consistent with the naming scheme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
atomspace good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linas @Syntactual