Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending to Azure OpenAI implementation #1470

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

pkt1583
Copy link

@pkt1583 pkt1583 commented Feb 23, 2024

This PR allows to use Azure OpenAI implementation. Since the API structure in openAI and Azure openAI is same the client can be initialised by looking at environment variable presence of AZURE_OPENAI_ENDPOINT. If we rely on CompletionFn endpoint then the code will still be more or less copy paste of existing OpenAI completionfn's

@SeryioGonzalez
Copy link

Azure OpenAI support would be an ideal add-on to this great tool.

@rogerpou
Copy link

rogerpou commented Jul 10, 2024

I've tested it and the oaieval gpt-3.5-turbo born-first --max_samples 10 and it works.
Just note that following your code the API Keys should be in this format:

return AzureOpenAI(
            api_key=os.environ.get("OPENAI_API_KEY"),
            azure_endpoint=os.environ.get("OPENAI_AZURE_ENDPOINT"),
            api_version=os.environ.get("OPENAI_API_VERSION"),
            azure_deployment=os.environ.get("OPENAI_AZURE_DEPLOYMENT"),
        )

@pkt1583
Copy link
Author

pkt1583 commented Aug 20, 2024

Can this be reviewed and merged? @andrew-openai @jwang47 @logankilpatrick @etr2460 @katyhshi

@pkt1583
Copy link
Author

pkt1583 commented Sep 5, 2024

Anyone available to review this PR? It has been lying around for quite some time

@mogokhalifa
Copy link

Any updates on merging this PR?

@pkt1583
Copy link
Author

pkt1583 commented Oct 9, 2024

running out of luck of getting attention of reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants