Also show number of manual reviews in stats

openSUSE · Oct 14, 2024 · ba047d7 · ba047d7
1 parent 9a0638c
commit ba047d7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/assets/vue/CavilStatistics.vue b/assets/vue/CavilStatistics.vue
@@ -12,6 +12,12 @@
         <div class="stats-description">Open Reviews</div>
       </div>
     </div>
+    <div class="col-md-2">
+      <div class="stats">
+        <div class="stats-body">{{ manualReviews }}</div>
+        <div class="stats-description">Manual Reviews</div>
+      </div>
+    </div>
     <div class="col-md-2">
       <div class="stats">
         <div class="stats-body">{{ rejectedPackages }}</div>
@@ -37,6 +43,7 @@ export default {
     return {
       activePackages: 0,
       embargoedPackages: 0,
+      manualReviews: 0,
       openReviews: 0,
       refreshDelay: 120000,
       refreshUrl: '/stats/meta',
@@ -48,6 +55,7 @@ export default {
       this.activePackages = data.active_packages;
       this.embargoedPackages = data.embargoed_packages;
       this.openReviews = data.open_reviews;
+      this.manualReviews = data.manual_reviews;
       this.rejectedPackages = data.rejected_packages;
     }
   }

diff --git a/lib/Cavil/Model/Packages.pm b/lib/Cavil/Model/Packages.pm
@@ -492,7 +492,8 @@ sub stats {
        (SELECT COUNT(*) FROM bot_packages WHERE obsolete = false) AS active_packages,
        (SELECT COUNT(*) FROM bot_packages WHERE obsolete = false AND embargoed = true) AS embargoed_packages,
        (SELECT COUNT(*) FROM bot_packages WHERE obsolete = false AND state = 'unacceptable') AS rejected_packages,
-       (SELECT COUNT(*) FROM bot_packages WHERE obsolete = false AND state = 'new') AS open_reviews"
+       (SELECT COUNT(*) FROM bot_packages WHERE obsolete = false AND state = 'new') AS open_reviews,
+       (SELECT COUNT(*) FROM bot_packages WHERE obsolete = false AND reviewing_user IS NOT NULL) AS manual_reviews"
   )->hash;
 
   return $stats;

diff --git a/t/stats.t b/t/stats.t
@@ -33,7 +33,7 @@ subtest 'Statistics' => sub {
 
   $t->get_ok('/stats')->status_is(200)->content_like(qr/id="statistics"/);
   $t->get_ok('/stats/meta')->status_is(200)->json_is('/active_packages', 2)->json_is('/embargoed_packages', 0)
-    ->json_is('/open_reviews' => 2)->json_is('/rejected_packages' => 0);
+    ->json_is('/open_reviews' => 2)->json_is('/rejected_packages' => 0)->json_is('/manual_reviews' => 0);
 
   $t->get_ok('/logout')->status_is(302)->header_is(Location => '/');
 };